Feature: Add rendering support for operation ID diff#881
Merged
DrSatyr merged 7 commits intoOpenAPITools:masterfrom Jan 9, 2026
Merged
Feature: Add rendering support for operation ID diff#881DrSatyr merged 7 commits intoOpenAPITools:masterfrom
DrSatyr merged 7 commits intoOpenAPITools:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/src/main/java/org/openapitools/openapidiff/core/output/HtmlRender.java">
<violation number="1" location="core/src/main/java/org/openapitools/openapidiff/core/output/HtmlRender.java:574">
P2: Missing null handling for operation ID values. If `getLeft()` or `getRight()` returns null, the output will display "null" in the rendered HTML. Consider adding null checks consistent with other methods in this file.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
core/src/main/java/org/openapitools/openapidiff/core/output/HtmlRender.java
Outdated
Show resolved
Hide resolved
Format
Contributor
Author
|
@DrSatyr any chance I could get a review on this please? |
Collaborator
|
Sorry, have busy days. Looks good from my perspective. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #880 I added support for flagging an operation ID change as a breaking change. However, I didn't add any rendering support for the operation ID changes. This meant that it might be unclear in some cases why a schema change was being marked as a breaking change.
To fix this, I've added rendering support for this type of change. However, the renderers will currently render the operation ID change regardless of whether it's configured to be recognised as a breaking change or not. I personally think that's fine, but I could be persuaded otherwise. I've done my best to match the style of the other diffs in the report.